-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GitPod button to nf-core usage tutorial #1094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @lescai !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually testing this out, the GitPod space has on the left menu all files part of the nf-core website. Would it be possible to get a "clean" GitPod space for the training?
in order for that to be possible, we should create a new nf-core repository instead of a config branch. |
Thinking about it more, I like the idea of a nf-core training repository. One could probably start with a clean repo by running:
but I think it would be nicer if we
and also open the training page in a preview panel (I don't think a learner should be looking at Markdown to start). |
got a reply from gitpod apparently it's possible to pass variables via URL |
ok this is now working. since gitpod receives the URL of the repo, there's a conflict with passing environmental variables with that syntax containing url characters. |
Suggestion for working view. |
Now that the config branch is merged, you can test the link here |
and... the welcome page opens again because the checkout I introduced to address @ggabernet request. |
Just tried the link but I get an error in the Gitpod terminal: $ gitpod /workspace/nf-co.re (gitpod_config_training) $ HISTFILE=/workspace/.gitpod/cmd-1 history -r; {
> parsed=`echo $url | tr -s "[" "/" | tr -s "+" "."`
> newurl="https://$parsed"
> gp preview $newurl
>
> }
Unable to connect to VS Code server: Error in request.
Error: connect ECONNREFUSED 127.0.0.1:23000
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1146:16) {
errno: -111,
code: 'ECONNREFUSED',
syscall: 'connect',
address: '127.0.0.1',
port: 23000
} But basically I'm happy to merge this PR whenever as I guess the Gitpod image itself is kind of separate from the PR that adds the button for it. |
I've noticed this happening in a few cases and it seems due to the "open" action being kicked off before the other actions have completed. |
Sure 👍🏻 |
@ewels I've tested a few things on the config (unfortunately another PR..) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
@emiller88 the changes to the workflow need to be on |
.github/workflows/fix-linting.yml
Outdated
repository: ${{ github.event.pull_request.head.repo.full_name }} | ||
ref: ${{ github.event.pull_request.head.ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work, as the action runs on the issue comment being added and not the PR event. So there is no github.event.pull_request
.
@emiller88 I removed your commits, hope that's ok 👍🏻 |
This PR simply adds a link that spins a GitPod environment, which automatically opens up the nf-co.re tutorial page on top of a terminal.
The environment is using the nf-core/gitpod image, and is configure to run nf-core tools and nextflow.
The button works if the branch
gitpod_config_training
in nf-co.re exists, since it has to store the correct config files.relates to #68