Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to cross-compile 32 and 64 bit dlls using MinGW #52

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

ChristophGr
Copy link
Contributor

No description provided.

@smortex
Copy link
Contributor

smortex commented Apr 3, 2017

Hey @nfc-tools/core and @nfc-tools/contributors, any Windows user to review this PR?

@smortex smortex self-requested a review April 4, 2017 08:13
Copy link
Contributor

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most information in README.md is valuable for Windows users, so it would be better to complete it than to introduce one more README file. Can you please move the Windows-specific parts in the Installation section, moving the current content in a On POSIX systems and your contribution in a On Windows systems (feel free to adjust labels)?

Thanks!

@ChristophGr
Copy link
Contributor Author

OK, I merged the two now

@smortex smortex merged commit 0db44b2 into nfc-tools:master Jun 9, 2017
@smortex
Copy link
Contributor

smortex commented Jun 9, 2017

Looks good! No contributor reported feedback for the feature itself, so I merged it.

Thanks!

@xavave
Copy link

xavave commented Jan 13, 2020

working good in 64bits with msys2 (mingw64 shell):
`
mkdir libfreefare-build
git clone https://github.com/nfc-tools/libfreefare.git
cd libfreefare-build
cmake -G "MinGW Makefiles" -DCMAKE_BUILD_TYPE=Release ../libfreefare -DLIBNFC_INCLUDE_DIRS=path/to/libnfc/include -DLIBNFC_LIBRARIES=/path/to/libnfc.dll

mingw32-make
`

and I had also to comment CmakeLists.txt, lines 41,43,44 to not force 32 bits

`# add_definitions("-m32")

add_definitions("-DNOCRYPT")

#set(CMAKE_SHARED_LINKER_FLAGS -m32)

#set(CMAKE_EXE_LINKER_FLAGS -m32)
`

image

cross-compiled binaries attached
examples.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants