Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issues on Windows #734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ikspress
Copy link
Contributor

@ikspress ikspress commented Jun 22, 2024

I attempted to solve compilation issues on Windows and I have revised my PRs serveral times. Hopefully this will be my last revision, maybe...

The purpose of this PR is as follows.

Accoring MSDN and mingw-w64, snprintf() works properly now. In #718, I took mingw-w64-crt's implementation of snprintf(), but it unchanged here.

@wizzomafizzo
Copy link

@ikspress Hi. Do you have any build instructions for this branch? I'm pretty keen to try it out but I don't have much experience compiling in windows. Thanks for your work!

@ikspress
Copy link
Contributor Author

ikspress commented Jul 12, 2024

@ikspress Hi. Do you have any build instructions for this branch? I'm pretty keen to try it out but I don't have much experience compiling in windows. Thanks for your work!

Hi. Would you mind tell me what environment you are using? MSYS2, MSVC or others?
If you want to run libnfc under MSYS2, there is already a compilation script here. Please refer to readme. If not, please tell me what you are using. If you have any trouble, feel free to tell me what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting macro definations in contrib/windows.h and errno.h
2 participants