Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] add "revert" mechanism #74

Closed
Brilator opened this issue Oct 16, 2023 · 4 comments
Closed

[Feature Request] add "revert" mechanism #74

Brilator opened this issue Oct 16, 2023 · 4 comments

Comments

@Brilator
Copy link
Member

Similar to #68, users asked for a "revert" button to revert changes

@Freymaurer
Copy link
Collaborator

This is a very difficult to manage request. Let's explore the following scenario:

User deletes assay

This will also delete datasets and lfs files(?)

We would need to store these files as state to which we can revert. Which might be doable but sounds rather difficult.

Is it feasable to apply this "revert" mechanism only to ISA files? Maybe with a warning for assay/study deletion, which tells the user that these changes are irreversible?

Let me know what you think @Brilator

@Brilator
Copy link
Member Author

Is it feasable to apply this "revert" mechanism only to ISA files? Maybe with a warning for assay/study deletion, which tells the user that these changes are irreversible?

That's definitely the main use case. During learning and first trials phase (often before adding data), users create their ARCs without perfect IDs for studies and assays in mind and often want to change that after a short time.

@JonasLukasczyk
Copy link
Collaborator

Reverting via git is already possible and ISA files have an undo stack in SWATE. So I think we can close this issue for now. Correct @Brilator ?

@Brilator
Copy link
Member Author

Brilator commented Feb 28, 2024

Yes! We've got revert in Swate. We've got reset.
And I guess renaming is on the agenda #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants