Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add options to delete individual studies and assays #68

Closed
Hannah-Doerpholz opened this issue Oct 13, 2023 · 6 comments
Assignees
Labels

Comments

@Hannah-Doerpholz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When I created an assay I accidentally also created a new study, which I didn't want. I could re-assign the assay but I was stuck with the remaining study. I then closed the ARCitect and manually deleted the study folder I didn't want. However, then I could now open the ARC anymore (likely because the study was still listed in the investigation.xlsx).

Describe the solution you'd like
We need a delete option for studies and assays respectively, that both deletes the respective folder, as well as updates the investigation.xlsx file.

Describe alternatives you've considered
It is probably possible to delete the folder manually and remove it from the investigation.xlsx, but this is not comfortable for the users since they have to know every place where the study/assay that shall be deleted is referenced.

@Brilator
Copy link
Member

Brilator commented Nov 2, 2023

Could this be a solution?

  1. user deletes (study / assay) folder or edits the name "by hand"
  2. ARCitect detects the change
  3. ARCitect opens a pop-up "ARCitect detected that study / assay XYZ was deleted / the file name was updated. Are you sure you want to delete / edit the name?"
  4. and offers two options: "undo change" "yes, update ARC / isa investigation"

@Freymaurer
Copy link
Collaborator

Added option to delete studies/assays from context menu (rightclick) on arc tree view ✨ beginning from v.0.0.17

@Freymaurer
Copy link
Collaborator

Ups: Will also enable deleting from folder directly, currently this should result in failing ARCs.

@Freymaurer Freymaurer reopened this Nov 17, 2023
@Brilator
Copy link
Member

Ups: Will also enable deleting from folder directly, currently this should result in failing ARCs.

It doesn't.
I can delete folders from ARC via Finder / Explorer. They disappear from ARCitect tree view, but will not be deleted from isa.investigation.xlsx

@Brilator
Copy link
Member

Deleting assays / studies via ARCitect (v.0.0.20) works like a charm though (on macOS)!

@Freymaurer
Copy link
Collaborator

Freymaurer commented Nov 22, 2023

Ups: Will also enable deleting from folder directly, currently this should result in failing ARCs.

It doesn't.
I can delete folders from ARC via Finder / Explorer. They disappear from ARCitect tree view, but will not be deleted from isa.investigation.xlsx

This is the expected behaviour. ARCitect will soon feature a list of registered studies/assays in invedtigation metadata, where this will be highlighted then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants