Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Protocol headers shifted to the right #108

Closed
HLWeil opened this issue Feb 12, 2021 · 3 comments
Closed

[BUG] Protocol headers shifted to the right #108

HLWeil opened this issue Feb 12, 2021 · 3 comments
Assignees
@Freymaurer
Labels
Host: Excel Issues regarding Excel interop Priority: Critical Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@HLWeil
Copy link
Member

HLWeil commented Feb 12, 2021

Describe the bug
After inserting a protocol through the upload protocol tool, the header is shifted one row to the right.

In the picture: The header peptide digestion should span the three parameters instead of the sample name

TableBug

To Reproduce

  1. Create new excel spreadsheet and load swate manifest.xml as add in
  2. Create new annotation table in swate
  3. Click on cell Source Name
  4. Load a protocol using the protocol insert function in swate

Expected behavior
The header should be spanned above the three parameters

OS and framework information (please complete the following information):

  • Excel online
  • Swate 0.3.0

Additional context
The CustomXML is correct, the problem seems to occur when rendering the information

CustomXmlLog
@HLWeil HLWeil added the Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. label Feb 12, 2021
@Freymaurer Freymaurer self-assigned this Feb 12, 2021
@Freymaurer Freymaurer added Host: Excel Issues regarding Excel interop Status: In Progress labels Feb 12, 2021
@Freymaurer
Copy link
Collaborator

This is a breaking bug, i will immediatly start working on it!

For now you can circumvent the bug by adding the table in EXACTLY row B.

Freymaurer added a commit that referenced this issue Feb 12, 2021
@Freymaurer
Fix protocol headers shifted if not placed in row B (Issue #108) 🐛
cbc655c
@Freymaurer
Copy link
Collaborator

I have fixed the bug and will move it to production. Will update this issue as soon as it is live.

@Freymaurer
Copy link
Collaborator

Fixed and should be live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freymaurer Freymaurer

Labels
Host: Excel Issues regarding Excel interop Priority: Critical Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HLWeil @Freymaurer