Skip to content

fix: bug with lambda function updates #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: bug with lambda function updates #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions aws_lambda/aws_lambda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,10 +704,14 @@ def update_function(
Publish=True,
)

# Wait for function to be updated
# Wait for function code to be updated
waiter = client.get_waiter('function_updated')
print("Waiting for code update to complete...")
waiter.wait(FunctionName=cfg.get("function_name"))

# Add a short delay to allow propagation
time.sleep(5)

kwargs = {
"FunctionName": cfg.get("function_name"),
"Role": role,
Expand Down Expand Up @@ -745,7 +749,21 @@ def update_function(
},
)

ret = client.update_function_configuration(**kwargs)
# Retry configuration update in case of conflicts
retries = 5
for attempt in range(retries):
try:
print("Updating function configuration...")
ret = client.update_function_configuration(**kwargs)
break
except client.exceptions.ResourceConflictException as e:
print(f"Conflict detected. Retrying... ({attempt + 1}/{retries})")
time.sleep(10) # Wait before retrying
else:
raise Exception(f"Failed to update function configuration after {retries} retries.")

# Add a short delay to allow propagation
time.sleep(5)

concurrency = get_concurrency(cfg)
if concurrency > 0:
Expand Down