Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readme #261

Merged
merged 1 commit into from
Apr 9, 2017
Merged

fix: readme #261

merged 1 commit into from
Apr 9, 2017

Conversation

hiroshi-cl
Copy link
Contributor

Thank you for your nice product. But I found two bugs in README.

  • The helmet instance does not contain titleAttributes
  • duplication of title tags

* helmet does not contain titleAttributes
* avoid duplication of title tags
@codecov
Copy link

codecov bot commented Mar 31, 2017

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files           3        3           
  Lines         277      277           
=======================================
  Hits          274      274           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5a7b1...dfd9406. Read the comment docs.

@cwelch5 cwelch5 merged commit a96db3f into nfl:master Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants