Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unexpected comma in server-rendered title #289

Merged
merged 1 commit into from
Jun 19, 2017
Merged

fix: Remove unexpected comma in server-rendered title #289

merged 1 commit into from
Jun 19, 2017

Conversation

doctyper
Copy link
Contributor

@doctyper doctyper commented Jun 1, 2017

Fixes #286

@codecov
Copy link

codecov bot commented Jun 1, 2017 •
edited
Loading

Codecov Report

Merging #289 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   98.92%   98.93%   +0.01%     
==========================================
  Files           3        3              
  Lines         278      281       +3     
==========================================
+ Hits          275      278       +3     
  Misses          3        3
Impacted Files Coverage Δ
src/HelmetUtils.js 98.59% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312229e...66b8212. Read the comment docs.

jamsea
jamsea approved these changes Jun 2, 2017
View reviewed changes
Copy link
Contributor

@jamsea jamsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

cwelch5
cwelch5 approved these changes Jun 10, 2017
View reviewed changes
Copy link
Contributor

@cwelch5 cwelch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cwelch5 cwelch5 merged commit 1af6e44 into master Jun 19, 2017
@tmbtech tmbtech deleted the issues/286 branch May 1, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwelch5 cwelch5 cwelch5 approved these changes

@jamsea jamsea jamsea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doctyper @jamsea @cwelch5