Skip to content

Commit

Permalink
nflfastR v3.0.0 (#100)
Browse files Browse the repository at this point in the history
* Increase Version Number

* Update Namespace and NEWS

* Update cran-comments

* incorporate master (#99)

* update example

* make examples knit

* Push CRAN release of v3.0.0
  • Loading branch information
mrcaseb authored Sep 25, 2020
1 parent b1c48ed commit 45121b7
Show file tree
Hide file tree
Showing 5 changed files with 55 additions and 11 deletions.
2 changes: 2 additions & 0 deletions CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This package was submitted to CRAN on 2020-09-24.
Once it is accepted, delete this file and tag the release (commit bec3afd).
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: nflfastR
Title: Functions to Efficiently Access NFL Play by Play Data
Version: 2.2.1.9009
Version: 3.0.0
Authors@R:
c(person(given = "Sebastian",
family = "Carl",
Expand Down
1 change: 0 additions & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,4 @@ importFrom(tidyr,unnest)
importFrom(tidyr,unnest_wider)
importFrom(tidyselect,any_of)
importFrom(tidyselect,ends_with)
importFrom(tidyselect,matches)
importFrom(xgboost,getinfo)
26 changes: 17 additions & 9 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,28 @@
# nflfastR (development version)
# nflfastR 3.0.0

## Breaking changes

* `fast_scraper_roster()` is finally back! It loads NFL roster of a given season.
* Added the function `decode_player_ids()` to decode all player IDs to the
commonly known GSIS ID format (00-00xxxxx)

## New features

* Add option `source = "old"` to `fast_scraper()` to enable scraping of old source.
This is mostly useless as it doesn't work for 2020 and provides less info
* `clean_pbp()` now fixes some bugs in jersey numbers
* Fix empty line causing `fast_scraper()` to fail (affects multiple games of the 2020 season)
* Fix bug in `fixed_drive` that counted PAT after defensive TD as its own drive
* `clean_pbp()`, `add_qb_epa()` and `add_xyac()` can now handle empty data frames
* Added new option `db_connection` to `update_db()` to allow advanced users to
use other DBI drivers, such as `RMariaDB::MariaDB()`, `RPostgres::Postgres()` or
`odbc::odbc()` (please see [dbplyr](https://dbplyr.tidyverse.org/articles/dbplyr.html)
for more information)
* Fixed a bug which caused too high number of tackles in special cases (#85)

## Minor improvements and fixes

* `clean_pbp()` now fixes some bugs in jersey numbers
* `clean_pbp()`, `add_qb_epa()` and `add_xyac()` can now handle empty data frames
* Fix empty line causing `fast_scraper()` to fail (affects multiple games of the 2020 season)
* Fix bug in `fixed_drive` that counted PAT after defensive TD as its own drive
* Fixed a bug which caused too high number of tackles in special cases
* Fixed a bug where CPOE was NA when targeting players with apostrophe in last name
* Added the function `decode_player_ids()` to decode all player IDs to the
commonly known GSIS ID format (00-00xxxxx)
* `fast_scraper_roster()` is finally back!

# nflfastR 2.2.1

Expand Down
35 changes: 35 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
## Release summary

This is a major release that
* adds the two exported functions `fast_scraper_roster()` as well as `decode_player_ids()`,
* adds a new option to the exported function `update_db()` and
* fixes some minor bugs.

## Test environments

* local R installation, R 4.0.2
* Debian Linux, R-devel, clang, ISO-8859-15 locale
* Debian Linux, R-devel, GCC
* Debian Linux, R-devel, GCC, no long double
* Debian Linux, R-patched, GCC
* Debian Linux, R-release, GCC
* Fedora Linux, R-devel, clang, gfortran
* Fedora Linux, R-devel, GCC
* CentOS 6 with Redhat Developer Toolset, R from EPEL
* macOS 10.13.6 High Sierra, R-release, brew
* macOS 10.13.6 High Sierra, R-release, CRAN's setup
* Ubuntu Linux 16.04 LTS, R-devel, GCC
* Ubuntu Linux 16.04 LTS, R-release, GCC
* Ubuntu Linux 16.04 LTS, R-devel with rchk
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
* Windows Server 2008 R2 SP1, R-oldrel, 32/64 bit
* Windows Server 2008 R2 SP1, R-patched, 32/64 bit
* Windows Server 2008 R2 SP1, R-release, 32/64 bit
* Linux (Xenial) (on travis-ci), R Versions oldrel, release, devel
* win-builder (devel)

## R CMD check results

0 errors | 0 warnings | 1 note

* unable to verify current time -> this is a R CMD Check problem

0 comments on commit 45121b7

Please sign in to comment.