Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with return touchdowns #21

Closed
TheMathNinja opened this issue Jun 21, 2020 · 4 comments
Closed

Problem with return touchdowns #21

TheMathNinja opened this issue Jun 21, 2020 · 4 comments

Comments

@TheMathNinja
Copy link
Contributor

I've found a large class of plays in which there were touchdown==1 but where pass_touchdown, rush_touchdown, and return_touchdown are all =0. These all seem to be fumble return TD's, and it seems to me they should be scored as return_touchdown = 1.

Examples include:
game_id 2019_03_NO_SEA, play_id 1399
game_id 2019_04_KC_DET, play_id 2657
game_id 2019_04_TB_LA, play_id 5000

@guga31bb
Copy link
Member

guga31bb commented Jun 21, 2020 via email

@TheMathNinja
Copy link
Contributor Author

I think touchdown == 1 is the right call here.

My question is this: why are you scoring INT touchdowns as return_touchdown == 1, but Fumble Recovery touchdowns are return_touchdown == 0? Shouldn't fumble recovery touchdowns be return_touchdown == 1 also?

@TheMathNinja
Copy link
Contributor Author

Or in other words, aren’t the following functions supposed to be related in this way?:
rush_touchdown + pass_touchdown + return_touchdown = touchdown?

@guga31bb
Copy link
Member

Yep this was a bug and has been fixed, which will be updated when we re-scrape (going to look at some of these other issues before doing that). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants