-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with return touchdowns #21
Comments
touchdown = 1 on these plays is expected behavior because a touchdown was
scored.
In practice, I usually detect offensive TDs with touchdown == 1 & td_team
== posteam.
I'll leave this open for now because maybe we should add a score_type
column or something
…On Sun, Jun 21, 2020, 15:16 TheMathNinja ***@***.***> wrote:
I've found a large class of plays in which there were touchdown==1 but
where pass_touchdown, rush_touchdown, and return_touchdown are all =0.
These all seem to be fumble return TD's, and it seems to me they should be
scored as return_touchdown = 1.
Examples include:
game_id 2019_03_NO_SEA, play_id 1399
game_id 2019_04_KC_DET, play_id 2657
game_id 2019_04_TB_LA, play_id 5000
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#21>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK37TIA4MSEKOSHRTLOS7TRXZL7JANCNFSM4OD7UMJA>
.
|
I think touchdown == 1 is the right call here. My question is this: why are you scoring INT touchdowns as return_touchdown == 1, but Fumble Recovery touchdowns are return_touchdown == 0? Shouldn't fumble recovery touchdowns be return_touchdown == 1 also? |
Or in other words, aren’t the following functions supposed to be related in this way?: |
Yep this was a bug and has been fixed, which will be updated when we re-scrape (going to look at some of these other issues before doing that). Thanks! |
I've found a large class of plays in which there were touchdown==1 but where pass_touchdown, rush_touchdown, and return_touchdown are all =0. These all seem to be fumble return TD's, and it seems to me they should be scored as return_touchdown = 1.
Examples include:
game_id 2019_03_NO_SEA, play_id 1399
game_id 2019_04_KC_DET, play_id 2657
game_id 2019_04_TB_LA, play_id 5000
The text was updated successfully, but these errors were encountered: