fix series and fixed_drive for muffed punts #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this closes #130 too right? |
|
Ha I was asking this myself too. Honestly I don't know. Since that issue was filed we have fixed the PAT bug and now the muffed punts. I didn't look that close to the remaining issues with series and drive so I can't tell if there are more edge case issues. We could close it with the comment that it can be reopened in case there are still problems. |
|
The cross reference to the issue in |
|
Looking a little more I think the only edge case left is fixed_drive and series incrementing on the kickoff attempt of a recovered onside kick. These are so rare I don't think I care to fix them. So I'll link that issue here too. |
This was
linked to
issues
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.