Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vegas_wpa, out_of_bounds, fantasy player columns #177

Merged
merged 26 commits into from
Feb 12, 2021
Merged

Conversation

guga31bb
Copy link
Member

@guga31bb guga31bb commented Feb 6, 2021

No description provided.

@guga31bb guga31bb linked an issue Feb 6, 2021 that may be closed by this pull request
@guga31bb
Copy link
Member Author

guga31bb commented Feb 6, 2021

Don't merge until after season since it adds columns

@mrcaseb
Copy link
Member

mrcaseb commented Feb 6, 2021

No that I see this I remember we have to add the new variables to the field_descriptions vignette.

I'll create a separate issue for that as we might add some more variables in the offseason

@guga31bb
Copy link
Member Author

guga31bb commented Feb 8, 2021

For some reason can't update variable list

image

@mrcaseb
Copy link
Member

mrcaseb commented Feb 8, 2021

For some reason can't update variable list

image

"For some reason" == "you are using outdated packages" hahaha

I will do it

@guga31bb guga31bb linked an issue Feb 11, 2021 that may be closed by this pull request
@guga31bb guga31bb linked an issue Feb 11, 2021 that may be closed by this pull request
@guga31bb guga31bb linked an issue Feb 11, 2021 that may be closed by this pull request
@guga31bb guga31bb linked an issue Feb 11, 2021 that may be closed by this pull request
@guga31bb guga31bb changed the title vegas_wpa Add vegas_wpa, out_of_bounds, fantasy player columns Feb 11, 2021
R/helper_additional_functions.R Outdated Show resolved Hide resolved
R/helper_additional_functions.R Outdated Show resolved Hide resolved
@guga31bb guga31bb merged commit ca4544d into master Feb 12, 2021
@guga31bb guga31bb deleted the vegas_wpa branch February 14, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants