resolve inconsistent datatype due to csv usage #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #325 |
|
Asking Tan for review as he knows what the pkgdown problem was |
|
Afk for a min but may I suggest adding a buffer to column size by about 5-10 characters / rounded up for all character types? Also pkgdown ok now
-
Tan Ho
…________________________________
From: mrcaseb ***@***.***>
Sent: Tuesday, May 17, 2022 3:07:24 PM
To: nflverse/nflfastR ***@***.***>
Cc: Tan Ho ***@***.***>; Review requested ***@***.***>
Subject: Re: [nflverse/nflfastR] resolve inconsistent datatype due to csv usage (PR #326)
Asking Tan for review as he knows what the pkgdown problem was
—
Reply to this email directly, view it on GitHub<#326 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJCRZ3Y4AN7KNLXNFFPQBRTVKPU6ZANCNFSM5WF4IC3Q>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
tanho63
approved these changes
May 25, 2022
There was a problem hiding this comment.
Not going to hold this up (maybe this resolves the issue @friscojosh was having?)
Can revisit extra padding later if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.