This repository was archived by the owner on Sep 11, 2022. It is now read-only.
Fix 411 and 410 Subsampling ratios in ycc.go #38
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37
The subsampling ratios were added in Go 1.5. Previously, trying to open an image with one of these ratios would fail before they could be resized. Since adding them, it is now possible to attempt to resize them, resulting in a runtime panic.
I see that the the travis tests are failing, due to the new ratios not being in the tested Go versions. I see two viable options: