Skip to content
This repository was archived by the owner on Sep 11, 2022. It is now read-only.

Add support for YCbCrSubsampleRatio411 and YCbCrSubsampleRatio410 #57

Closed

Conversation

charlievieth
Copy link
Contributor

This commit adds support for the YCbCrSubsampleRatio411 and
YCbCrSubsampleRatio410 subsample ratios introduced in Go 1.5
and maintains backwards compatibility with older versions of
Go.

This commit adds support for the YCbCrSubsampleRatio411 and
YCbCrSubsampleRatio410 subsample ratios introduced in Go 1.5
and maintains backwards compatibility with older versions of
Go.
@unixpickle
Copy link

How is this different than #39 ?

@charlievieth
Copy link
Contributor Author

charlievieth commented Feb 21, 2017

@unixpickle Thanks for the reminder, that was so long ago I forgot I even did that and was just trying to help with #51.

Took a look at #39 and the only delta is that pre-go15 stuff is now in files named *_go14.go (which is good, because they only exist for backwards compatibility) and the tests in this PR maintain backwards compatibility in a simpler way (the current test file remains ycc_test.go - new ratios are added in ycc_go15_test.go).

Also, it appears Travis does not like this commit - likely due to test file ycc_test_go15.go not being named ycc_go15_test.go - thats now fixed.

@charlievieth
Copy link
Contributor Author

charlievieth commented Feb 18, 2018

@unixpickle I'm closing this - the changes are in: #39.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants