Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: linkifyStr doesn't work with apostrophe and an alphabetical character #488

Closed
patrickReiis opened this issue Aug 27, 2024 · 2 comments · Fixed by #499
Closed

BUG: linkifyStr doesn't work with apostrophe and an alphabetical character #488

patrickReiis opened this issue Aug 27, 2024 · 2 comments · Fixed by #499
Assignees
Labels
bug parsing Related to string parsing

Comments

@patrickReiis
Copy link

I am using Deno.

I work with a technology called nostr, and the following string nostr:npub1gujeqakgt7fyp6zjggxhyy7ft623qtcaay5lkc8n8gkry4cvnrzqd3f67z is converted to patrick.

However, if the string I just mentioned has an apostrophe plus another character it doesn't work.

Like this: nostr:npub1gujeqakgt7fyp6zjggxhyy7ft623qtcaay5lkc8n8gkry4cvnrzqd3f67z's

I actually created a new repository just dedicated for this issue, in the line 32 you can change the argument so it becomes the variable in the line 27 or 28.

Link: https://github.com/patrickReiis/linkify-mention

I could try to fix this on my own, since I have a specific parser with {render: {url: <specific-parser>}}, but I think it should work under the hood already, without me having to worry about it.

@nfrasser nfrasser self-assigned this Dec 4, 2024
@nfrasser nfrasser added bug parsing Related to string parsing labels Dec 4, 2024
nfrasser added a commit that referenced this issue Dec 4, 2024
Fixes #488, should end URL if encountered.
@nfrasser
Copy link
Owner

nfrasser commented Dec 4, 2024

@patrickReiis apologies for the delayed reply, the fix for this is now available in the latest v4.2.0 release.

@patrickReiis
Copy link
Author

Thanksssssss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug parsing Related to string parsing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants