Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-? queries pick up trailing parenthesis #81

Closed
dmassant opened this issue Oct 22, 2015 · 1 comment
Closed

post-? queries pick up trailing parenthesis #81

dmassant opened this issue Oct 22, 2015 · 1 comment
Assignees

Comments

@dmassant
Copy link

Thanks for the great library, man - this have been very helpful.

I'm getting a strange behavior in a corner case and wanted to let you know:

In the last case, that trailing parenthesis gets picked up in the url.

@nfrasser
Copy link
Owner

Hi @dmassant, this behaviour is intentional, due to the fact that some URLs contain parentheses. e.g., https://en.wikipedia.org/wiki/Blur_(band). We've already had a few issues regarding this problem, such as #52. Determining whether to include or to exclude a trailing parens from a URL would require some additional lexical analysis that may degrade this plugin's performance. This post goes more into detail about that: http://blog.codinghorror.com/the-problem-with-urls/

We have looked at several ways and tricks to solving this problem, such as a flag that's set when there are parens in the query string. However, these will take some time to implement, and again, we don't want to degrade performance.

For now, I can't offer a real workaround other than ensuring URLs are padded with whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants