Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with ( and ) in it #52

Closed
Polfo opened this issue Jan 15, 2015 · 3 comments · Fixed by #74
Closed

Links with ( and ) in it #52

Polfo opened this issue Jan 15, 2015 · 3 comments · Fixed by #74
Milestone

Comments

@Polfo
Copy link

Polfo commented Jan 15, 2015

First of all, thanks for this great useful tool and the time and effort you put in it.

I noticed a link to a page containing () does not work.
http://nl.wikipedia.org/wiki/L%27Oiseau_bleu_(theaterstuk) converts to http://nl.wikipedia.org/wiki/L%27Oiseau_bleu_(theaterstuk)
shown as code:

<a href="http://nl.wikipedia.org/wiki/L%27Oiseau_bleu_" class="linkified" target="_blank">http://nl.wikipedia.org/wiki/L%27Oiseau_bleu_</a>(theaterstuk)</td>
@nfrasser
Copy link
Owner

Yup, this is a known problem (see #22 ). #51 will have a fix for this.

@nfrasser nfrasser mentioned this issue Jan 15, 2015
30 tasks
@Polfo
Copy link
Author

Polfo commented Jan 17, 2015

Sorry for posting this duplicate, did not notice.

@nfrasser nfrasser modified the milestone: 2.0 Jan 28, 2015
@kevinrenskers
Copy link

#51 does not fully fix the problem:

The closing ) of https://en.wikipedia.org/wiki/Company_(military_unit) is not part of the link

<a href="https://en.wikipedia.org/wiki/Company_(military_unit" class="linkified" target="_blank">https://en.wikipedia.org/wiki/Company_(military_unit</a>)

nfrasser pushed a commit that referenced this issue Jun 27, 2015
* Parentheses and other symbols are now included as part of the
  URL. Fixes #52
* Allow numbers as domains and subdomains. Fixes #71
* Colons are no longer allowed in an email address's local part.
  Fixes #73

Test case updates have been included
@nfrasser nfrasser mentioned this issue Jun 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants