Feat/461-473 #491
Merged
Feat/461-473 #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d2632d0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9cf56666.nft-storage.pages.dev |
alanshaw
reviewed
Sep 30, 2021
There was a problem hiding this comment.
- How are we dealing with new users/nfts that are created after a sync?
- How do we sync a deleted NFT?
- How do we deal with the ordering of inserts to postgres and our foreign key constraints? Is it this?:
- Insert users
- Insert auth keys
- Insert content (normalized from
PINS) - Insert pins (derived from
PINS) - Insert uploads (
NFTS)
- What are the tasks that have to be done during the downtime? i.e. after the initial sync has been done, but more data has arrived
- What time estimate do we have for this?
- How are we syncing the
PINStable? I see no code for this... - Can you confirm these are no longer needed:
NFTS_IDXcan just queryupload where user_id = X order by inserted_at DESCetc.FOLLOWUPSwe can just querypins where service = 'IpfsCluster' AND status <> PinnedDEALSis FDW & materialized viewsMETRICSquery postgres directly for now? yesPINATA_QUEUEwe can just querypins where service = 'Pinata' AND status <> Pinned
| @@ -40,7 +51,8 @@ CREATE TABLE IF NOT EXISTS auth_key | |||
| secret TEXT NOT NULL, | |||
| account_id BIGINT NOT NULL REFERENCES account (id), | |||
| inserted_at TIMESTAMP WITH TIME ZONE DEFAULT timezone('utc'::text, now()) NOT NULL, | |||
| updated_at TIMESTAMP WITH TIME ZONE DEFAULT timezone('utc'::text, now()) NOT NULL | |||
| updated_at TIMESTAMP WITH TIME ZONE DEFAULT timezone('utc'::text, now()) NOT NULL, | |||
| UNIQUE (name, account_id) | |||
There was a problem hiding this comment.
These can be deleted so they need a deleted_at field and so cannot have this constraint, same as uploads. We can't undelete these - if a user deletes one and then creates a new one with the same name the old one should not start working again.
19 tasks
alanshaw
reviewed
Oct 1, 2021
| `) | ||
| } | ||
|
|
||
| run() |
There was a problem hiding this comment.
This can be removed. I ported it to #496
alanshaw
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.