Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not delete auth keys #539

Merged
merged 2 commits into from
Oct 7, 2021
Merged

feat: do not delete auth keys #539

merged 2 commits into from
Oct 7, 2021

Conversation

hugomrdias
Copy link
Contributor

No description provided.

@hugomrdias hugomrdias requested a review from alanshaw October 7, 2021 11:53
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2021 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6b9bd66
Status: ✅  Deploy successful!
Preview URL: https://1c5260bf.nft-storage.pages.dev

View logs

alanshaw
alanshaw previously approved these changes Oct 7, 2021
View reviewed changes
@alanshaw alanshaw dismissed their stale review October 7, 2021 13:23

Some things are missing from the PR I thought of after the review.

alanshaw
alanshaw requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@alanshaw alanshaw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getUser needs to be changed so that it doesn't return deleted keys. I think that in this PR you can still use a deleted key to upload content.

@hugomrdias hugomrdias requested a review from alanshaw October 7, 2021 14:14
alanshaw
alanshaw approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alanshaw alanshaw mentioned this pull request Oct 7, 2021
Closed
19 tasks
@hugomrdias hugomrdias merged commit d1b07e0 into main Oct 7, 2021
@hugomrdias hugomrdias deleted the feat/deleted-keys branch October 7, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomrdias @alanshaw