-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add /store endpoint to API schema #693
Conversation
Hmm, I just realized that I didn't add docs for the response body. Will add tomorrow. |
@yusefnapora ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions to simplify things a bit, otherwise looks great! Thanks for doing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include @Gozala's changes before merging. Otherwise this is great.
Deploying with Cloudflare Pages
|
I started to add a note about content types to the API docs, but it seems that the
/store
endpoint wasn't in the schema, just/upload
.So this adds docs for the
/store
endpoint based on what I could glean from the code. Someone should probably look it over to make sure it's correct.May need some formatting tweaks and so on - I wasn't able to run the website build locally, since my env isn't set up, so I haven't seen it rendered yet.
Also closes #490 - we actually allow all file types now, but I added a recommendation to only use images for the
image
field.