Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redirect to dweb link when ipns #25

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Apr 13, 2022

This PR addresses first step to support IPNS. It handles /ipns resolution and subdomain resolution by simply redirecting to dweb.link in the end.

Redirect to DNS safe representation rules:

A follow up PR should address adding support for IPNS resolution proxying it to the gateway race. We need to refactor some CID specific logic and (perhaps?) get independent metrics to IPNS response times. (will create an issue)

CF configuration needed changes:

Closes #24

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 13, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4aa8578
Status: ✅  Deploy successful!
Preview URL: https://a28b465e.nftstorage-link.pages.dev

View logs

@vasco-santos vasco-santos force-pushed the fix/redirect-to-dweb-link-when-ipns branch from 55ec21c to d423086 Compare April 13, 2022 13:55
@vasco-santos vasco-santos force-pushed the fix/redirect-to-dweb-link-when-ipns branch from d423086 to 4aa8578 Compare April 13, 2022 13:56
Copy link

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@vasco-santos vasco-santos changed the title fix: redirect to dweb link when ipns feat: redirect to dweb link when ipns Apr 13, 2022
@vasco-santos vasco-santos merged commit da81710 into main Apr 13, 2022
@vasco-santos vasco-santos deleted the fix/redirect-to-dweb-link-when-ipns branch April 13, 2022 14:15
This was referenced Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/ipns/ path returns invalid response with ads
2 participants