Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add provideAlainConfig #1689

Merged
merged 4 commits into from
Nov 10, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add ng-update
cipchk committed Nov 10, 2023
commit 8620d2e9bb5cf08bf44828606292128f1b1bd37b
8 changes: 8 additions & 0 deletions schematics/ng-update/upgrade-rules/v17/index.spec.ts
Original file line number Diff line number Diff line change
@@ -63,4 +63,12 @@ describe('Schematic: ng-update: v17Rule', () => {
const content = tree.readContent(globalConfigPath);
expect(content).not.toContain(`AlainThemeModule.forRoot()`);
});

it('#replaceProvideAlainConfig', async () => {
const globalConfigPath = '/projects/foo/src/app/global-config.module.ts';
tree.create(globalConfigPath, `const alainProvides = [{ provide: ALAIN_CONFIG, useValue: alainConfig }];`);
await runMigration();
const content = tree.readContent(globalConfigPath);
expect(content).toContain(`provideAlainConfig(alainConfig)`);
});
});
9 changes: 8 additions & 1 deletion schematics/ng-update/upgrade-rules/v17/index.ts
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@ import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';

import { autoRegisterFormWidgets } from './autoRegisterFormWidgets';
import { removeAlainThemeModuleForRoot } from './removeAlainThemeModuleForRoot';
import { replaceProvideAlainConfig } from './replaceProvideAlainConfig';
import { logFinished, logInfo, logWarn } from '../../../utils';
import { UpgradeMainVersions } from '../../../utils/versions';

@@ -30,6 +31,12 @@ export function v17Rule(): Rule {
return async (tree: Tree, context: SchematicContext) => {
UpgradeMainVersions(tree);
logInfo(context, `Upgrade dependency version number`);
return chain([removeAlainThemeModuleForRoot(), autoRegisterFormWidgets(), qr(), finished()]);
return chain([
removeAlainThemeModuleForRoot(),
autoRegisterFormWidgets(),
replaceProvideAlainConfig(),
qr(),
finished()
]);
};
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { Rule, SchematicContext, Tree } from '@angular-devkit/schematics';

import { DEFAULT_WORKSPACE_PATH, logInfo, readJSON } from '../../../utils';

export function replaceProvideAlainConfig(): Rule {
return (tree: Tree, context: SchematicContext) => {
const angularJson = readJSON(tree, DEFAULT_WORKSPACE_PATH);
const projectNames = Object.keys(angularJson.projects);
for (const name of projectNames) {
run(tree, name, angularJson.projects[name].sourceRoot, context);
}
};
}

function run(tree: Tree, name: string, sourceRoot: string, context: SchematicContext): void {
const filePath = `${sourceRoot}/app/global-config.module.ts`;
if (!tree.exists(filePath)) return;

const text = '{ provide: ALAIN_CONFIG, useValue: alainConfig }';
const content = tree.readText(filePath).replace(text, 'provideAlainConfig(alainConfig)');
tree.overwrite(filePath, content);

logInfo(context, `Use provideAlainConfig instead of ALAIN_CONFIG in ${name} project`);
}