Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating with custom template sticky hover #2178

Closed
alc86 opened this issue Feb 20, 2018 · 5 comments
Closed

Rating with custom template sticky hover #2178

alc86 opened this issue Feb 20, 2018 · 5 comments

Comments

@alc86
Copy link

alc86 commented Feb 20, 2018

The rating control with an custom template does strange things at hover. If you spin around with your mouse some times the UI displays the wrong content. Its hard to describe and so I have create a show video and a Plunker example to reproduce.

Plunker:
http://plnkr.co/edit/tEIKFOoGzUP8HCBnyhE4?p=preview

Video:
Plunker - Google Chrome 20.02.2018 10_42_32.zip

@maxokorokov
Copy link
Member

maxokorokov commented Feb 22, 2018

Looks like resurfaced #1204
However I can't reproduce in any of the browsers on the macOS this time.

@pkozlowski-opensource pkozlowski-opensource added this to the 1.0.2 milestone Mar 2, 2018
@pkozlowski-opensource
Copy link
Member

I can't reproduce either... @alc86 what is the exact OS / browser version that you are using?

@alc86
Copy link
Author

alc86 commented Mar 6, 2018

I use windows 10 with Google Chrome.

@tschuegge
Copy link

alc86 and I have tested this:

  • macOS
    • Chrome: easy to reproduce
    • Firefox: harder to reproduce
    • Safari: impossible to reproduce
  • Windows
    • Chrome: easy to reproduce
    • Firefox: harder to reproduce
    • Edge: impossible to reproduce
    • IE 11: impossible to reproduce

Steps to reproduce:

  1. Click on the first heart
  2. Move the mouse immediately and fast outside on the right side (over the hearts)

@maxokorokov
Copy link
Member

maxokorokov commented Mar 16, 2018

Ok, the problem is that we were conditionally removing and adding DOM nodes in the rating template in the demo. When moving cursor from left to right DOM nodes were recreated and:

  • mouseenter on a star was triggered twice (old node, then new node)
  • mouseleave on the whole rating component was not triggered sometimes (depending on the mouse move speed)

(see PR for updated demo, note that in the demo rating is readonly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants