Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timepicker: Setting minuteStep undefined #2851

Closed
Bogdanel opened this issue Nov 7, 2018 · 2 comments
Closed

timepicker: Setting minuteStep undefined #2851

Bogdanel opened this issue Nov 7, 2018 · 2 comments
Labels
component: timepicker type: bug
Milestone
4.0.2

Comments

@Bogdanel
Copy link

Bogdanel commented Nov 7, 2018

Bug description:

Setting input minuteStep to undefined on timepicker will set time to null when decreasing minutes, and it will act normal on increasing minutes.

Expected: throw an error that minuteStep is undefined, or get notified somehow.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 7.0.1

ng-bootstrap: 4.0.0

Bootstrap: 4.0.0
@pkozlowski-opensource
Copy link
Member

https://github.com/ng-bootstrap/ng-bootstrap#you-think-youve-found-a-bug

@pkozlowski-opensource pkozlowski-opensource added this to the Purgatory milestone Nov 22, 2018
@Bogdanel
Copy link
Author

Stackblitz : https://stackblitz.com/edit/angular-ngbtimepicker-minutestep

@benouat benouat removed this from the Purgatory milestone Dec 3, 2018
@avsorokin avsorokin mentioned this issue Dec 5, 2018
Merged
@maxokorokov maxokorokov modified the milestones: 4.0.1, 4.0.2 Dec 13, 2018
maxokorokov pushed a commit that referenced this issue Dec 17, 2018
@avsorokin @maxokorokov
fix(timepicker): handle setting hour/minute/second step to 'undefined'
34baece 
Fixes #2851 
Closes #2903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: timepicker type: bug
Projects
None yet
Milestone
4.0.2
Development

No branches or pull requests
4 participants
@pkozlowski-opensource @benouat @Bogdanel @maxokorokov