feat(tooltip): trigger tooltips with hover and focus by default

[bastienmoulia]

Don't know if it's an oversight or if it's the right way to do it, but in Bootstrap the tooltips are triggered by hover and focus, and ng-boostrap use only the hover.

https://getbootstrap.com/docs/4.3/components/tooltips/#options
VS
https://ng-bootstrap.github.io/#/components/tooltip/api

[mendeza]

Thank you for mentioning this, Bastien. It’s needed for WCAG compliance. _ Thanks, Aaron

…

________________________________ From: Bastien <notifications@github.com> Sent: Wednesday, February 13, 2019 17:38 To: ng-bootstrap/ng-bootstrap Cc: Subscribed Subject: [ng-bootstrap/ng-bootstrap] feat(tooltip): trigger tooltips with hover and focus by default (#3022) Don't know if it's an oversight or if it's the right way to do it, but in Bootstrap the tooltips are triggered by hover and focus, and ng-boostrap use only the hover. https://getbootstrap.com/docs/4.3/components/tooltips/#options<https://urldefense.proofpoint.com/v2/url?u=https-3A__getbootstrap.com_docs_4.3_components_tooltips_-23options&d=DwMCaQ&c=4ZIZThykDLcoWk-GVjSLmy8-1Cr1I4FWIvbLFebwKgY&r=o5K88bCUJq1JpN1QCx4k6WsuKEQP9_ZQwKI-xg9YzxQ&m=6ardS1qADEtNUcIbFDYQLjy_7Ufe2KmNatKY0Vwn46M&s=LcEv3FwXEfaX2OrEQ5R7vXqby7Qc8UC16osKvu-RcDw&e=> VS https://ng-bootstrap.github.io/#/components/tooltip/api<https://urldefense.proofpoint.com/v2/url?u=https-3A__ng-2Dbootstrap.github.io_-23_components_tooltip_api&d=DwMCaQ&c=4ZIZThykDLcoWk-GVjSLmy8-1Cr1I4FWIvbLFebwKgY&r=o5K88bCUJq1JpN1QCx4k6WsuKEQP9_ZQwKI-xg9YzxQ&m=6ardS1qADEtNUcIbFDYQLjy_7Ufe2KmNatKY0Vwn46M&s=dJvBx7KN3QFCCUkh7im6LCXKBH5oyxkSvmEMVeTVgHA&e=> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ng-2Dbootstrap_ng-2Dbootstrap_issues_3022&d=DwMCaQ&c=4ZIZThykDLcoWk-GVjSLmy8-1Cr1I4FWIvbLFebwKgY&r=o5K88bCUJq1JpN1QCx4k6WsuKEQP9_ZQwKI-xg9YzxQ&m=6ardS1qADEtNUcIbFDYQLjy_7Ufe2KmNatKY0Vwn46M&s=iYKNOZPIkkkFEe6zZI6KED0cV6cZnGdSI7FyAOfjtuA&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABG4QDi-2Dk1QCK-2DneDKU0kivAQVXH41Jeks5vNJPUgaJpZM4a6a-2Dk&d=DwMCaQ&c=4ZIZThykDLcoWk-GVjSLmy8-1Cr1I4FWIvbLFebwKgY&r=o5K88bCUJq1JpN1QCx4k6WsuKEQP9_ZQwKI-xg9YzxQ&m=6ardS1qADEtNUcIbFDYQLjy_7Ufe2KmNatKY0Vwn46M&s=8MC8oii94c1-KM_aEMTo2NtQcy08fe7sEZ0GXePskZo&e=>.

[maxokorokov]

Indeed looks like the default value should be: "hover focus"

A quick test shows that "hover focusin:focusout" works fine.
We don't have a "focus" alias in the triggers.ts, so it should be added there to allow for "hover focus" to work

P.S. popover should stay with "click" as default

[maxokorokov]

This should be an easy PR, but if anybody wants to work on this, please add an e2e test for focus handling here → https://github.com/ng-bootstrap/ng-bootstrap/tree/master/e2e-app/src/app/tooltip

[hasegao]

It looks pretty straightforward updating the Tooltip default to "hover focus" in the tooltip config, and adding "focus" alias to triggers.ts

Will submit a PR alone with e2e test as mentioned.