fix(accordion): comply with bootstrap markup #1332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbt
changed the title
5 tasks
jiayihu
reviewed
Mar 15, 2017
| </h5> | ||
| </div> | ||
| <div id="{{panel.id}}" class="collapse" [class.show]="isOpen(panel.id)" role="tabpanel" | ||
| [attr.aria-labelledby]="panel.id + '-header'"> |
There was a problem hiding this comment.
This should add *ngIf check to support current behaviour where closed panels are removed from DOM.
fix ng-bootstrap#1050 Removed similar IDs from demos
pkozlowski-opensource
added
blocked: Bootstrap CSS issue
and removed
needs: review
labels
|
It is currently blocked on the Bootstrap 4 issue, see #1050 (comment) |
rmeans
pushed a commit
to fcsa-teamhammer/ng-bootstrap
that referenced
this pull request
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1050
Removed similar IDs from demos
Before submitting a pull request, please make sure you have at least performed the following: