Skip to content

perf: add teardown logic for watch #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2018
Merged

perf: add teardown logic for watch #980

merged 1 commit into from
Jun 27, 2018

Conversation

alan-agius4
Copy link
Member

When the observable has complete or errored. The watch should be closed.

I'm submitting a...

[ ] Bug Fix
[ ] Feature
[x] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

apply tier down logic so that when observable completes we close the watcher and thus avoid memory leaks

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

When the observable has complete or errored. The watch should be closed.
@dherges dherges merged commit 42ffec4 into ng-packagr:master Jun 27, 2018
@alan-agius4 alan-agius4 deleted the add-tear-down branch June 27, 2018 10:55
@github-actions
Copy link

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants