69and70 #71
Merged
69and70 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure if this is the best approach.
sjudeng
reviewed
Jun 7, 2018
|
|
||
| if (entry == null) | ||
| { | ||
| entry = source.get(name); |
There was a problem hiding this comment.
Can you add a test to cover this case?
|
|
||
| Object entry = source.get(keys.get(0)); | ||
|
|
||
| if (entry == null) |
There was a problem hiding this comment.
Add curly brace on this line for style consistencey (if (entry == null) {).
sjudeng
approved these changes
Jun 10, 2018
This was referenced Jun 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69 Resolved null values when attributes contain dots. Not sure if this is the best approach.
#70 Resolved conflicting getter definitions