feat: better windows support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better support for Windows paths when used in cygwin or Git Bash. Note that you will have to npm config set script-shell "C:\\path\\to\\bash.exe" to the bash executable that ships with either of those. Also, yarn run is temporarily busted (they have a fix on master) when using that config so you will need to use npm run in the meantime.
|
This should probably also involve running the tests under Windows. I'll look into that. |
|
Looks like Travis only supports |
|
I have confirmed that this fix allows for builds under git bash in Windows. |
schmidtk
approved these changes
Aug 13, 2019
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better support for Windows paths when used in cygwin or Git Bash. Note that you will have to
npm config set script-shell "C:\\path\\to\\bash.exe"to the bash executable that ships with either of those. Also,yarn runis temporarily busted (they have a fix on master) when using that config so you will need to usenpm runin the meantime.