Fix menu toggle #714
Merged
Fix menu toggle #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 7, 2019 09:42
|
Export test fails:
|
|
Also, #697 can probably be closed with this PR. |
That error is unrelated and will randomly happen on |
justin-bits
approved these changes
Aug 7, 2019
wallw-teal
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu toggle behavior was implemented with a blacklist of elements that shouldn't toggle, and instead always open a new menu. The grid wasn't in the blacklist and doesn't support toggling the menu, causing the menu to be closed while leaving the open flag set to
true. This changes the behavior to support menu toggle on buttons and button groups.Updated Cypress tests to remove the workaround for #667, and updated the screenshot following the default icon fix for #676.