Remove Hardcoded Platform in PYOPENGL_PLATFORM
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for your amazing work on this repository! I have been trying to use the visualization tools in
src/body_visualizer/tools/vis_tools.pyand encountered issues with PyOpenGL. The fix was to follow this here: MPI-IS/mesh#66When installing this library with pip,
pip install git+https://github.com/nghorbani/body_visualizer, the code within the file that overwrites the environment variablePYOPENGL_PLATFORMto always beeglcan cause issues. Like in the linked issue, we needed the platform to be set atosmesafor our render code to work.I've also add the small change in the function
meshes_as_pngin the same file. The change makes no functional difference, but the argument order in the constructor ofMeshViewerwas flipped so that width was height and height was width. This is just so that future readers of this code may save a minute or two figuring out why their images look odd if they change the height and width to other values that are not square.