Automatic creation of default cert and private key #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And prepare functions for the default certificate test unit.
JrCs
previously approved these changes
Aug 12, 2018
|
Under which section of the doc do you think this should go ? |
|
Feel free to choose. Just a little sentence to said that we can use default self-signed certificates. |
|
Travis is having network related issues since two days ago, might be a while before the tests finally succeed. |
JrCs
approved these changes
Aug 12, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #411 (and the related #74 #373 #416 and #420).
This PR check at container startup if both
default.crtanddefault.keyare present in/etc/nginx/certsand create them otherwise. This auto-created certificate is self signed, has subject CN=letsencrypt-nginx-proxy-companion and is valid for 365 days.If the startup function detect a user provided default certificate and key (ie a certificate which subject does not match
letsencrypt-nginx-proxy-companion), it won't overwrite it.If the startup function detect an auto-created certificate which remaining validity is less than three months, it will re-create a new one.
Some test units and functions had to be modified / expanded to take this new feature into account.
This feature comes with its own test unit.