Simplify the self cid discovery mechanism #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the hard requirement that the container get its self cid during entrypoint as it is only used to produce a warning and to get the nginx-proxy container id through --volumes-from, which is only one of the three methods. The fact that the LE container could get an nginx-proxy container id is independently verified by the entrypoint script anyway and this hard requirement on getting its self cid has been known to cause troubles with containers running under orchestrators such as Amazon ECS or Kubernetes.
This was referenced Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR greatly simplify the self cid discovery code and remove the hard requirement that the container get its self cid during entrypoint, as it is only used to produce a warning and to get the
nginx-proxycontainer id through--volumes-from, which is only one of the three methods.The fact that the LE container could get an
nginx-proxycontainer id is independently verified by the entrypoint script anyway and this hard requirement on getting its self cid has been known to causetroubles with containers running under orchestrators such as Amazon ECS or Kubernetes.