Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LETSENCRYPT_KEYSIZE feature and tests #727

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Fix LETSENCRYPT_KEYSIZE feature and tests #727

merged 4 commits into from
Dec 8, 2020

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Dec 8, 2020

This PR fix:

  • the LETSENCRYPT_KEYSIZE feature that was accepting values not compatible with Let's Encrypt
  • the CI tests that were not actually comparing the test output to an expected empty output.

The test suite is now also able (as it should) to test any image passed as argument rather than jrcs/letsencrypt-nginx-proxy-companion only.

@buchdag buchdag added kind/bug Issue reporting a bug type/docs PR with documentation only changes type/ci PR that change the CI configuration files and scripts labels Dec 8, 2020
@buchdag buchdag merged commit 1752a42 into nginx-proxy:master Dec 8, 2020
@buchdag buchdag deleted the ci-fix branch December 8, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug Issue reporting a bug type/ci PR that change the CI configuration files and scripts type/docs PR with documentation only changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@buchdag