Filter containers to notify #549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably needs a test in order to get merged. |
|
@josegonzalez, what kind of test it needs? Can't find anything similar. |
|
Superseded by #619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives ability to specify set of filters to containers query when new generated file arrived.
It is kinda similar to #311 but with better implementation from architectural point of view.
It introduces new command line argument
-notify-filterthat adds filter in list of filters to query containers that should be notified when generated file changed. Argument format as in docker apiFor example:
adds two filters to containers query.
Signal code still defined by argument
-notify-signal.