Fixup forego to work with nginx-proxy's alpine variant #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple processes were immediatly crashing on startup, the environment map was written concurrently in multiple goroutines. This caused forego to crash in certain situations. To protect against this behavior, this commit protects multiple concurrent accesses by using a sync.Map instead.
This commit removes variables that are not used.
This reverts commit 51d9f6d.
This commit moves the shell command to be used when executing commands into a variable, allowing it to be customized at build time using a command like: go build -ldflags "-X main.osShell=my-fancy-shell" -o forego
|
Very nice work, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accumulates various fixes to make forego work with the latest nginx-proxy image on both the debian and alpine image. These are:
alpinebecause theshshell does not support all required features.osShellso that the shell can be customized at forego build time. For example:can be used to make forego always use
shas opposed tobash.envmap against concurrent accesses, these occur when a process crashes immediately on startup.