Skip to content

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Apr 18, 2025

Proposed changes

Added enable disable features check

  • Added logs informing user that feature is disabled and whats features are enabled
  • Removed Connection feature as most other features are not usable without it
  • Otel Plugin no longer starts if metrics feature is disabled
  • Certificates feature is now checked when parsing the nginx config, if feature is disabled we skip the cert

Features:
FeatureConfiguration = Default ON
FeatureMetrics = Default ON
FeatureFileWatcher = Default ON
FeatureAPIAction = Default OFF
FeatureLogsNap = Default OFF
FeatureCertificates = Default OFF

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Apr 18, 2025
@aphralG aphralG requested a review from a team as a code owner April 18, 2025 09:53
@github-actions github-actions bot added chore Pull requests for routine tasks enhancement New feature or request labels Apr 18, 2025
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Apr 18, 2025
@aphralG aphralG merged commit 4ae7de6 into v3 Apr 25, 2025
20 checks passed
@aphralG aphralG deleted the enable-disable-features branch April 25, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks enhancement New feature or request v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants