Skip to content

Update file watcher to only monitor directories referenced in the nginx configuration #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Update file watcher to only monitor directories referenced in the nginx configuration #1134

wants to merge 17 commits into from

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Jun 17, 2025 •
edited
Loading

Proposed changes

  • Update file watcher to only monitor directories referenced in the nginx configuration.
  • Ensure that any opened files are closed correctly.
  • If watcher fails to be created then retry even 5 seconds (default file watcher monitoring period).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Jun 17, 2025
@dhurley dhurley requested a review from a team as a code owner June 17, 2025 14:58
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Jun 17, 2025
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Jun 17, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
aphralG
aphralG reviewed Jun 23, 2025
View reviewed changes
aphralG
aphralG reviewed Jun 23, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@dhurley dhurley

Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhurley @aphralG