-
Notifications
You must be signed in to change notification settings - Fork 100
[CI/CD] Improve assertion doc generation #1400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 102 102
Lines 12622 12622
=======================================
Hits 10890 10890
Misses 1253 1253
Partials 479 479 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
dhurley
approved these changes
Nov 21, 2025
craigell
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the assertion document generation as an option when running the release branch workflow.
For the assertion doc, we need to generate a few extra files to pass along, mainly:
These get stored in files alongside the binary which is created in
make package, and these files along with the binary itself are stored to GitHub artifacts.When 'Store assertion document' option is selected:
When running the Assertion doc workflow manually:
Run IDof the pipeline which created the build artifacts, if they are still in GitHub the workflow will download these, and proceed with the workflow as normal.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)