-
Notifications
You must be signed in to change notification settings - Fork 120
NGF: Gateway API Inference Extension doc #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good other than the edits suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM: added edit suggestions for formatting conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with some nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Blocked until approval from Legal regarding warning call out. |
d63adba
to
28dfcdb
Compare
Changed PR to merge into main, this PR will go in after #1351 gets merged, which merges the EDIT: rebasing completed |
28dfcdb
to
35f066a
Compare
The check with legal has proceeded and this PR is no longer blocked. |
Proposed changes
Add document for Gateway API Inference Extension work.
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩