Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from nginxinc to nginx #7103

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Update from nginxinc to nginx #7103

merged 5 commits into from
Jan 15, 2025

Conversation

lucacome
Copy link
Member

Proposed changes

Updates references from nginxinc

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome requested review from a team as code owners January 10, 2025 03:13
@github-actions github-actions bot added documentation Pull requests/issues for documentation dependencies Pull requests that update a dependency file go Pull requests that update Go code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code tests Pull requests that update tests helm_chart Pull requests that update the Helm Chart labels Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.74%. Comparing base (a5eef74) to head (231b09d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7103      +/-   ##
==========================================
- Coverage   52.76%   52.74%   -0.02%     
==========================================
  Files          89       89              
  Lines       20831    20831              
==========================================
- Hits        10992    10988       -4     
- Misses       9382     9384       +2     
- Partials      457      459       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes LGTM.

Copy link
Contributor

@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  • codeowners groups don't exist. I think this should be fixed first before merging this (blocker)
  • there are a bunch of updates to dependencies along with the org change, is this expected / desirable in this PR? (not a blocker)

.github/workflows/release.yml Show resolved Hide resolved
CODEOWNERS Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@javorszky javorszky self-requested a review January 14, 2025 09:20
@lucacome lucacome merged commit 6128b8f into main Jan 15, 2025
74 of 75 checks passed
@lucacome lucacome deleted the chore/nginx branch January 15, 2025 06:28
nginx-bot pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

4 participants