-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from nginxinc to nginx #7103
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7103 +/- ##
==========================================
- Coverage 52.76% 52.74% -0.02%
==========================================
Files 89 89
Lines 20831 20831
==========================================
- Hits 10992 10988 -4
- Misses 9382 9384 +2
- Partials 457 459 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
- codeowners groups don't exist. I think this should be fixed first before merging this (blocker)
- there are a bunch of updates to dependencies along with the org change, is this expected / desirable in this PR? (not a blocker)
Proposed changes
Updates references from
nginxinc
Checklist
Before creating a PR, run through this checklist and mark each as complete.