Move CRDs to config directory (#1798)

Problem: The CRDs are generated inside the helm chart directory instead
of the standard config directory.

Solution: Modify the output parameter of the CRDs generation to save
them in the config directory. Also add symlinks to the other locations
where we expect to find CRDs.

Author: lucacome

Diff for: .yamllint.yaml

@@ -5,7 +5,7 @@ yaml-files:
 
 ignore:
   - deploy/helm-chart/templates/
-  - deploy/helm-chart/crds/
+  - config/crd/bases/
   - .github/workflows/
 
 rules:
@@ -30,7 +30,6 @@ rules:
     check-multi-line-strings: true
     ignore: |
       deploy/manifests/nginx-gateway.yaml
-      deploy/manifests/crds
   key-duplicates: enable
   key-ordering: disable
   line-length:
@@ -40,7 +39,6 @@ rules:
     ignore: |
       .github/
       deploy/manifests/nginx-gateway.yaml
-      deploy/manifests/crds
       tests/suite/manifests/longevity/cronjob.yaml
       .goreleaser.yml
   new-line-at-end-of-file: enable

Diff for: Makefile

@@ -100,12 +100,10 @@ generate: ## Run go generate
 
 .PHONY: generate-crds
 generate-crds: ## Generate CRDs and Go types using kubebuilder
-	go run sigs.k8s.io/controller-tools/cmd/controller-gen crd paths=./apis/... output:crd:dir=deploy/helm-chart/crds
-	go run sigs.k8s.io/controller-tools/cmd/controller-gen object paths=./apis/...
+	go run sigs.k8s.io/controller-tools/cmd/controller-gen crd object paths=./apis/... output:crd:artifacts:config=config/crd/bases
 
 .PHONY: generate-manifests
 generate-manifests: ## Generate manifests using Helm.
-	cp $(CHART_DIR)/crds/* $(MANIFEST_DIR)/crds/
 	helm template nginx-gateway $(CHART_DIR) $(HELM_TEMPLATE_COMMON_ARGS) $(HELM_TEMPLATE_EXTRA_ARGS_FOR_ALL_MANIFESTS_FILE) -n nginx-gateway | cat $(strip $(MANIFEST_DIR))/namespace.yaml - > $(strip $(MANIFEST_DIR))/nginx-gateway.yaml
 	helm template nginx-gateway $(CHART_DIR) $(HELM_TEMPLATE_COMMON_ARGS) $(HELM_TEMPLATE_EXTRA_ARGS_FOR_ALL_MANIFESTS_FILE) --set nginx.plus=true --set nginx.image.repository=$(NGINX_PLUS_PREFIX) -n nginx-gateway | cat $(strip $(MANIFEST_DIR))/namespace.yaml - > $(strip $(MANIFEST_DIR))/nginx-plus-gateway.yaml
 	helm template nginx-gateway $(CHART_DIR) $(HELM_TEMPLATE_COMMON_ARGS) $(HELM_TEMPLATE_EXTRA_ARGS_FOR_ALL_MANIFESTS_FILE) --set nginxGateway.gwAPIExperimentalFeatures.enable=true -n nginx-gateway | cat $(strip $(MANIFEST_DIR))/namespace.yaml - > $(strip $(MANIFEST_DIR))/nginx-gateway-experimental.yaml

Diff for: deploy/helm-chart/crds/gateway.nginx.org_nginxgateways.yaml renamed to config/crd/bases/gateway.nginx.org_nginxgateways.yaml

@@ -0,0 +1 @@
+../../config/crd/bases

Diff for: deploy/helm-chart/crds

@@ -0,0 +1 @@
+../../config/crd/bases