Move CRDs to config directory #1798
Merged
+4
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The CRDs are generated inside the helm chart directory instead of the standard config directory. Solution: Modify the output parameter of the CRDs generation to save them in the config directory. Also add symlinks to the other locations where we expect to find CRDs.
github-actions
bot
added
chore
lucacome
commented
Apr 2, 2024
sjberman
reviewed
Apr 2, 2024
|
I didn't see anything in the docs that needs to be changed, it should all work the same with the symlink |
sjberman
approved these changes
Apr 2, 2024
kate-osborn
reviewed
Apr 2, 2024
pleshakov
approved these changes
Apr 2, 2024
kate-osborn
approved these changes
Apr 3, 2024
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: The CRDs are generated inside the helm chart directory instead of the standard config directory. Solution: Modify the output parameter of the CRDs generation to save them in the config directory. Also add symlinks to the other locations where we expect to find CRDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The CRDs are generated inside the helm chart directory instead of the standard config directory.
Solution: Modify the output parameter of the CRDs generation to save them in the config directory. Also add symlinks to the other locations where we expect to find CRDs.
Closes #1740
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.