You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
go: finding module for package sigs.k8s.io/gateway-api/apis/v1/validation
go: github.com/nginxinc/nginx-gateway-fabric/internal/mode/static/state imports
sigs.k8s.io/gateway-api/apis/v1/validation: package sigs.k8s.io/gateway-api/apis/v1/validation provided by sigs.k8s.io/gateway-api at latest version v1.0.0 but not at required version v1.0.1-0.20240125175351-1edf7e93ae4b
make: *** [Makefile:26: update-go-modules] Error 1
Error: Process completed with exit code 2.
Expected behavior
no failure
Your environment
Additional context
The reason for failure is Gateway API removed validation package used by Webhook.
compare:
Per an offline conversation, the likely approach when we upgrade to 1.1 of the Gateway API is to remove this validation and let the CRDs be the sole source of validation (except for a single validation case which I believe is still needed in the code, can't remember off the top of my head what that case is).
Also need to ensure that we remove any panics that we currently have for validation failures, and instead use logs and events.
mpstefan
added
tracking
To track external issues or changes that will affect NKG
backlog
Currently unprioritized work. May change with user feedback or as the product progresses.
tests
Pull requests that update tests
and removed
backlog
Currently unprioritized work. May change with user feedback or as the product progresses.
tracking
To track external issues or changes that will affect NKG
labels
Feb 5, 2024
Describe the bug
As of Jan 29 2024, nightly conformance tests fail
To Reproduce
See https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/7691006269/job/20955653116
Expected behavior
no failure
Your environment
Additional context
The reason for failure is Gateway API removed validation package used by Webhook.
compare:
However, we also used that package to rerun Webhook validation, according to https://github.com/nginxinc/nginx-gateway-fabric/blob/b77e9c2a42ba57f6228056d56a986eed4f531083/design/resource-validation.md
Conformance tests started failing in Dec -- https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/7204325805 -- after this was merged in the Gateway API repo kubernetes-sigs/gateway-api@052e0d1
The text was updated successfully, but these errors were encountered: