-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove webhook validation code #1590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Feb 15, 2024
One validation is not supported by CEL and needs to be implemented manually: kubernetes-sigs/gateway-api#2277 |
ciarams87
force-pushed
the
fix/remove-webhook
branch
from
February 16, 2024 12:01
224099c
to
008e7e4
Compare
sjberman
reviewed
Feb 16, 2024
pleshakov
reviewed
Feb 16, 2024
ciarams87
force-pushed
the
fix/remove-webhook
branch
from
February 19, 2024 11:30
008e7e4
to
fcc5ce8
Compare
ADubhlaoich
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the docs side of things.
sjberman
approved these changes
Feb 20, 2024
kate-osborn
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pleshakov
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The webhook validation code has been removed from the upstream Gateway API repo, causing import errors when we try and run the conformance tests against the main branch of the Gateway API repo.
Solution: Remove the web hook validation code from our repo, and remove the web hook assumption panics. Also add additional validation for case not covered by CEL validation (see kubernetes-sigs/gateway-api#2277)
Testing: Added additional unit tests where appropriate, ran the conformance test suite against the GW API main branch
Closes #1512
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.