Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary build of NGF #1680

Closed
pleshakov opened this issue Mar 13, 2024 · 0 comments · Fixed by #1681
Closed

Avoid unnecessary build of NGF #1680

pleshakov opened this issue Mar 13, 2024 · 0 comments · Fixed by #1681
Labels
bug Something isn't working

Comments

@pleshakov
Copy link
Contributor

Problem:
When building an NGF image, building NGF binary will always happen,
even if it's not needed (Docker build target is not local)

Introduced in 799ea76
@pleshakov pleshakov added the bug Something isn't working label Mar 13, 2024
pleshakov added a commit to pleshakov/nginx-gateway-fabric that referenced this issue Mar 13, 2024
@pleshakov
Avoid unnecessary build of NGF
b128439 
Problem:
When building an NGF image, building NGF binary will always happen,
even if it's not needed (Docker build target is not local)

Solution:
Fix it by adding a stage for a container that holds CA certs.

Introduced in 799ea76

Closes nginx#1680
@pleshakov pleshakov mentioned this issue Mar 13, 2024
Merged
5 tasks
pleshakov added a commit that referenced this issue Mar 13, 2024
@pleshakov
Avoid unnecessary build of NGF (#1681)
92c2910 
Problem:
When building an NGF image, building NGF binary will always happen,
even if it's not needed (Docker build target is not local)

Solution:
Fix it by adding a stage for a container that holds CA certs.

Introduced in 799ea76

Closes #1680
amimimor pushed a commit to amimimor/nginx-gateway-fabric that referenced this issue Apr 3, 2024
@pleshakov @amimimor
Avoid unnecessary build of NGF (nginx#1681)
48fb770 
Problem:
When building an NGF image, building NGF binary will always happen,
even if it's not needed (Docker build target is not local)

Solution:
Fix it by adding a stage for a container that holds CA certs.

Introduced in 799ea76

Closes nginx#1680
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this issue Jan 14, 2025
@miledxz
Avoid unnecessary build of NGF (nginx#1681)
9f20eff 
Problem:
When building an NGF image, building NGF binary will always happen,
even if it's not needed (Docker build target is not local)

Solution:
Fix it by adding a stage for a container that holds CA certs.

Introduced in 799ea76

Closes nginx#1680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid unnecessary build of NGF pleshakov/nginx-gateway-fabric
1 participant
@pleshakov