-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more detail to helm install commands #1299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Some environments may not want to have a Service installed by default. Our instructions for installing via helm are not clear about this. Solution: Update helm installation docs to be clear about how to alter the installation commands. Also cleaned up the commands/docs a bit.
✅ Deploy Preview for nginx-gateway-fabric ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bjee19
approved these changes
Nov 30, 2023
ciarams87
approved these changes
Dec 1, 2023
ADubhlaoich
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kate-osborn
approved these changes
Dec 4, 2023
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: Some environments may not want to have a Service installed by default. Our instructions for installing via helm are not clear about this. Solution: Update helm installation docs to be clear about how to alter the installation commands. Also cleaned up the commands/docs a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Some environments may not want to have a Service installed by default. Our instructions for installing via helm are not clear about this.
Solution: Update helm installation docs to be clear about how to alter the installation commands. Also cleaned up the commands/docs a bit.