Add telemetry job - option 2 #1392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is PoC for feedback - Use Manager leader election intead of our own - Add telemetry job with a Stdout Exporter - Report telemetry every 10s (good enough for PoC)
kate-osborn
reviewed
Dec 15, 2023
| if err != nil { | ||
| return err | ||
| } | ||
| if err = mgr.Add(&enableOnLeaderElectedJob{enable: statusUpdater.Enable}); err != nil { |
There was a problem hiding this comment.
Smart way to do this without a big refactor 👍
|
Always a fan of utilizing all that controller-runtime has to offer, so I do prefer this option. |
6 tasks
|
Thanks for the feedback. I will proceed with this approach and move this PR from draft to ready to review once it is ready. |
|
closing in favor of #1448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for high-level (design) feedback.
Proposed changes
This is PoC for feedback
Upgrading from edge version (which uses different (our own, not Manager) leader election) was ok:
Update:
Lease before:
Lease after:
Closes #1382
Checklist
Before creating a PR, run through this checklist and mark each as complete.